Found with clang -Wstrict-bool.

Found with clang -Wstrict-bool.

Found with clang -Wstrict-bool.

Found with clang -Wstrict-bool.

Erroneously assumed the number of reserved bytes (for the return code) could not decrease.

perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib-sieve: util: program-client-remote: Made the program_client_istream implementation cleaner and more logical.

It was too hard to understand.

lib-sieve: util: program-client: Fixed position of the seekable stream for the output of remote programs.

It would now make the output of the script service seekable, rather than the output of the program.
This adds a '+' at the end of the data.
This showed up for the extprograms filter command.

set_cache_corrupted_reason was removed in core.

lib-sieve: relational extension: Replaced return statement with i_unreached() in mcht_value_match_key().

Coverity still complained.

Caused minor complaints by Coverity.

Minor complaint by Coverity.

imapsieve plugin: Fixed potential segfault bug caused by shadowing a parameter with a local variable.

Renamed the local variable.
Found by Coverity.

MAIL_FETCH_UIDL_FILE_NAME was removed from core.

imapsieve plugin: Fixed crash occurring when a mailbox is opened for a user before the imap client object is created.

This simplifies the code significantly.
This also removes calls to i_stream_get_data(), which caused problems after its semantics were changed in Dovecot.

lib-sieve: lexer: Adjusted to Dovecot change: i_stream_get_data() no longer returns NULL when returned size = 0.

In effect, this adds PIE and RELRO to binaries.

extprograms plugin: Clarified the language specification regarding handling of filter and execute errors.

extprograms plugin: Execution errors in filter and execute commands did not lead to script termination.

lib-sieve: program client: Fixed bug in handling of result code from remote program (script service).

It was sometimes passed through as data, meaning that the result code was missed.
This transiently resulted in programs seemingly returning invalid result codes, causing an error.

lib-sieve: vacation extension: The sieve_user_email setting is now used in check for implicit delivery.

This means that vacation responses are now also sent for messages that include the sieve_user_email address in one of the relevant headers.

Added assertion to validation function.