It doesn't match Dovecot convention.

mailbox_get_last_error() should be used only for client-visible errors.
The internal errors should be used for logging.

Found by latest clang scan-build.

This makes the use of compound literal explicit.

The tests blow through these limits all of the time, which
makes the logs very noisy. These three cases are about 4/5ths
of the test logs. Presumably they're the ones that are also
most often needing expansion in real world use too.

Signed-off-by: Phil Carmody <phil@dovecot.fi>

The str_append_n() function is now deprecated. At no occasion, the occurence of
NUL in the data is possible or relevant, so each instance is replaced with
str_append_data() rather than str_append_max().

Only calls that require space allocation are to be changed.

Now using struct smtp_address rather than sieve_address.
In some cases, struct message_address may prove to be more suitable, but this is the best fit for now.
Adjusted to the renamed fields in struct mail_deliver_context.

The situation where no headers are found was not always handled correctly.

Used the following script:

C_FILES=`git ls-files *.c`
H_FILES=`git ls-files *.h`
for F in "$C_FILES $H_FILES"; do
        echo "$F"
  perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F
  perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F
  perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F
  perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F
done

perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

This prevents trouble with o_stream_nsend_istream() later.

The previous change prompted some futher code review and similar improvements/fixes were applied at various places in the code.

Futher changes are needed to prevent accessing the envelope in the first place.

Added support for getting message part information and content.

lib-sieve: mime extension: Fixed the header :mime :anychild test to work properly outside a foreverypart loop.

lib-sieve: message body: Fixed erroneous changes to the message part tree structure performed when re-parsing the message.

lib-sieve: message body: Fixed assert failure occurring when text extraction is attempted on a empty or broken text part.