The settings were already read at this point, so this didn't actually do
anything. Fixing the code to actually set it would break existing tests,
so just remove it.

Also change the callers to not bother storing it separately. Instead, they
can just use mail_user_r->service_user.

Fixes argument list too long error.

Change was:

lib-mail: message_address_parse() - Change fill_missing parameter to flags

Signed-off-by: Phil Carmody <phil@dovecot.fi>

The parent event doesn't really matter here, so NULL is used.

Now using struct smtp_address rather than sieve_address.
In some cases, struct message_address may prove to be more suitable, but this is the best fit for now.
Adjusted to the renamed fields in struct mail_deliver_context.

Rather than continuing with binary == NULL, causing a segfault.

Used the following script:

C_FILES=`git ls-files *.c`
H_FILES=`git ls-files *.h`
for F in "$C_FILES $H_FILES"; do
        echo "$F"
  perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F
  perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F
  perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F
  perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F
done

perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

Parallel to identical Dovecot change.

Some environment items in the base specification are not (yet) applicable to Dovecot and are therefore not supported.

Before, sievec and sieve-dump would switch to mail_uid:mail_gid and then fail to compile/dump a root script.