Otherwise stats process startup can get into a loop.

Makes it easier to run with valgrind.

Dovecot core doesn't have copyright notices in header files.

The flag has been removed, and the setting is now the default.

Also dropped the single-letter identifier for most fields to prevent conflicts with mail user variables; these were undocumented anyway.

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	timeout_remove(&E);
	- }
	+ timeout_remove(&E);

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove(&E);
	- }
	+ io_remove(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove_closed(&E);
	- }
	+ io_remove_closed(&E);

This follows the following commits in Dovecot:
lib-storage: Moved connection information in struct mail_user into separate struct mail_user_connection_data.
lib-storage: mail-user: Added more information about the client connection.

Call master_login_init() before master_service_init_finish(), which frees
all the data stack done in initialization.

This didn't normally cause any visible problems, because data stack wasn't
currently being used in a way that the strings were invalidated. However,
it was causing failures if --enable-devel-checks was used.

Patch by Andreas Schulze.

It's replaced with fd-util.h which is automatically included now.

Mirrors imap fix in Dovecot: 42149f48624b82fdf9631c256497580154c2e412

It's impossible for the command's pointer to be NULL at this point.
Previously, the command_find() would have returned NULL, but this check
presumably short-circuits that search in the trivial case, so has some
real use.

Problem now found by GCC 7.

This used strftime() directly and allocated memory from the heap before i_fatal().
It also used printf() to send the BYE message, which will only work right when the service is running stand-alone.

path-util is a merge of realpath from Pigeonhole and abspath from core.

Used the following script:

C_FILES=`git ls-files *.c`
H_FILES=`git ls-files *.h`
for F in "$C_FILES $H_FILES"; do
        echo "$F"
  perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F
  perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F
  perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F
  perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F
done

Apparently, this causes GCC warnings.

This avoids accidents with the array numbering being wrong.

This at least partially replaces the "rawlog" post-login binary. For now
the "rawlog" binary supports some parameters, which aren't configurable
for rawlog_dir.

There is no reason to forbid an empty Sieve script.

Clang -Wvargargs complained about passing a bool argument to va_start().

Found with clang -Wstrict-bool.

perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

In effect, this adds PIE and RELRO to binaries.

Plain t_malloc was deprecated in dovecot.

This could have happened with Maildir/mbox and autoexpunging.
Mimics Dovecot/IMAP change ddffbb277e212adb9d594b3d7d1e1d39fa78f7c6.