The validate hook only worked for one extension.

Erroneously set pointer to NULL in sieve_storage_list_deinit().

lda-sieve plugin: Dereferenced default script storage at wrong nesting level, causing an assert failure.

LDAP storage as a plugin is still not problem-free though.

Directory iteration was very broken.

Doveadm-sieve plugin may be broken at this point; not tested so far.

Most important change is that mail service_user was not freed.

Would cause a segfault.
Reported by Coverity.

Handling of edit_mail_header_find() result was incoherent.
Problem reported by Coverity.

Reported by Coverity.

Switch statement item is never reached and return value was bool instead of int.
Problem reported by Coverity.

Forgot a few '*' there.
Reported by Coverity.

Forgot break in switch statement.
Reported by Coverity.

lib-sieve: program client: Forgot break in switch statement for handling of response from script service.
Reported by Coverity.

Reported by Coverity.

Reported by Coverity.

Parallel to identical Dovecot change.

Parallel to identical Dovecot change for imap and pop3.

Reported by Coverity.

Reported by Coverity.

Found by Coverity.

A va_copy creates a initialised va_list, as if a va_start had been done on it.
Therefore, pedantically, a va_end should also be done on it. On most platforms
this is a no-op, and for those where it isn't, the pairing is important.

This change matches parallel change in Dovecot. Also signalled by Coverity.