Although it was documented and implemented in essence, it was not actually
available.

Fixes e.g. FILTER+LOGOUT pipelining crash:
Panic: file imap-sync.c: line 832 (cmd_sync_delayed_real): assertion failed: (client->mailbox != NULL)

Before, the whole address list (header value) was returned as an invalid
address, ignoring any valid addresses it may still have contained.

It adds the ability to manually invoke Sieve filtering in IMAP.

Use the new SIEVE_EXECUTE_FLAG_SKIP_RESPONSES flag to prevent any unforseen
mishaps.

This causes the reject and vacation response actions to be skipped without
error.

Signed-off-by: Phil Carmody <phil@dovecot.fi>

The tests blow through these limits all of the time, which
makes the logs very noisy. These three cases are about 4/5ths
of the test logs. Presumably they're the ones that are also
most often needing expansion in real world use too.

Signed-off-by: Phil Carmody <phil@dovecot.fi>

Signed-off-by: Phil Carmody <phil@dovecot.fi>

It is the initial working directory and that may change during testing, so it is
not a good idea to determine this per test.

The problem mainly arose because the stream buffer position was used to
determine how much was written, while the stream buffer position is potentially
decreased by i_stream_try_alloc().

Panic was:

Panic: file istream.c: line 197 (i_stream_read): assertion failed: ((size_t)ret+old_size == _stream->pos - _stream->skip)

The str_append_n() function is now deprecated. At no occasion, the occurence of
NUL in the data is possible or relevant, so each instance is replaced with
str_append_data() rather than str_append_max().

Always return SIEVE_EXEC_KEEP_FAILED instead.

Always return SIEVE_EXEC_KEEP_FAILED instead.

lib-sieve: vacation extension: Enforce subject header limit in Unicode codepoints rather than bytes.

This conversion now includes a check that may fail. Pigeonhole currently only
uses this functionality to obtain an SMTP version of the postmaster address.
This code is now consolidated in the sieve_get_postmaster_smtp() function, which
provides postmaster address as an SMTP address.

Errors will trigger an implicit keep, not discard.

lib-sieve: variables extension: Fix duplicate const in definition of sieve_variables_modifier array.

This is wrong and leads to Clang compiler warnings.

This is now logged as a debug message instead.

This is a remnant of an older implementation and now triggered a scan-build report.

This occurred for example when the "fileinto" command is used with only the
"copy" extension in the require line.

Panic message was:

Panic: file hash.c: line 263 (hash_table_insert_node): assertion failed: (opcode == HASH_TABLE_OP_UPDATE)

Previously, this was only tested implicitly in the Sieve test suite. Now, it is
tested explicitly, which allows for more flexibility in the testing scenario.

It now extensively tests one scenario that used to fail.

This caused an assert panic when the application or child stream did not skip
all buffered data immediately. This was reproducible only when the message input
stream consisted of a concatenation of smaller streams, which is used in LMTP to
prepend a few headers.

The panic was:

Panic: file istream.c: line 329 (i_stream_read_memarea): assertion failed: ((size_t)ret+old_size == _stream->pos - _stream->skip)