This makes more sense with the managesieve_command_name field.

Also dropped the single-letter identifier for most fields to prevent conflicts with mail user variables; these were undocumented anyway.

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	timeout_remove(&E);
	- }
	+ timeout_remove(&E);

Cleanup performed with the following semantic patch:

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove(&E);
	- }
	+ io_remove(&E);

	@@
	expression E;
	@@

	- if (E != NULL) {
	- 	io_remove_closed(&E);
	- }
	+ io_remove_closed(&E);

Mirrors imap fix in Dovecot: 42149f48624b82fdf9631c256497580154c2e412

It's impossible for the command's pointer to be NULL at this point.
Previously, the command_find() would have returned NULL, but this check
presumably short-circuits that search in the trivial case, so has some
real use.

Problem now found by GCC 7.

This used strftime() directly and allocated memory from the heap before i_fatal().
It also used printf() to send the BYE message, which will only work right when the service is running stand-alone.

Used the following script:

C_FILES=`git ls-files *.c`
H_FILES=`git ls-files *.h`
for F in "$C_FILES $H_FILES"; do
        echo "$F"
  perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F
  perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F
  perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F
  perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F
done

Apparently, this causes GCC warnings.

This avoids accidents with the array numbering being wrong.

This at least partially replaces the "rawlog" post-login binary. For now
the "rawlog" binary supports some parameters, which aren't configurable
for rawlog_dir.

Clang -Wvargargs complained about passing a bool argument to va_start().

Found with clang -Wstrict-bool.

Plain t_malloc was deprecated in dovecot.

This could have happened with Maildir/mbox and autoexpunging.
Mimics Dovecot/IMAP change ddffbb277e212adb9d594b3d7d1e1d39fa78f7c6.

Mimics Dovecot/IMAP change 1001bda65e9f592d852a26ddd6a993f7973050bf.

This allows completely disabling Sieve processing for a particular user.

Changed handling of ENOSPACE to a normal temporary failure and added handling of ENOQUOTA as a user error.
Patch by Timo Sirainen.

Doveadm-sieve plugin may be broken at this point; not tested so far.

Most important change is that mail service_user was not freed.

Parallel to identical Dovecot change for imap and pop3.

This change is bigger than I would have liked, so this needs to be tested more.