Über Open CoDE Software Wiki Diskussionen GitLab

Skip to content

Feat/flavor v3 make disks recommended

Kurt Garloff requested to merge feat/flavor-v3-make-disks-recommended into main

Created by: garloff

Notes on this PR:

  • It consists of several steps (commits) that can be reviewed individually
    • Copy old v2 standard, add distinction b/w mandatory and recommended in text and in test tools (--v3 aka -3 option), add SSD flavors from 0110-v1 as mandatory.
  • The last step could in theory also add the SSD flavors as recommended only
  • In --v3 mode, missing recommended flavors will create a warning, but no compliance error
  • The test tools currently work with just one version of the required flavor file. This is currently broken by not dropping the SSD flavors from v2 and v1 tests -- this may need a different approach. (Maybe I would continue to use one version of the file with the required flavors, but annotate the new SSD ones, or create two versions or just hardcode dropping them without --v3. That latter is a bit hacky, admittedly.)
  • wavestack and regio.digital both currently pass the v3 tests already (SSD flavors exist), ps fails by not having the new v2 names yet nor the SSD flavors.
  • we would still have to decide when this standard becomes valid and when v1 and v2 are phased out.

Merge request reports

Loading