Now using struct smtp_address rather than sieve_address.
In some cases, struct message_address may prove to be more suitable, but this is the best fit for now.
Adjusted to the renamed fields in struct mail_deliver_context.

It doesn't serve a purpose either, since parsing "from" address from URI is not allowed for notify mailto.

lib-sieve: store action: Avoid NULL pointer dereference during rollback when transaction context is somehow unassigned.

This change matches the other transaction stages.
This will not currently happen though.
Reported by Coverity.

Otherwise the error status is overwritten.
Problem found by Coverity.

Used the stream's cur_header field, rather than the local variable.
Problem found by Coverity.

The merge_from_parent() function may not actually read anything, potentially leaving the stream buffer unassigned.
Problem found by Coverity.

This makes the implementation easier to understand and amend once Dovecot APIs changes.
This implicitly makes the implementation suitable for the new istream snapshot handling.

Added assertions on subtractions.
Restructured the code for clarity.
Added comments.

Ported Dovecot's istream-jsonstr for ManageSieve syntax.

Call master_login_init() before master_service_init_finish(), which frees
all the data stack done in initialization.

This didn't normally cause any visible problems, because data stack wasn't
currently being used in a way that the strings were invalidated. However,
it was causing failures if --enable-devel-checks was used.

Patch by Andreas Schulze.

Patch by Andreas Schulze.

Patch by Andreas Schulze.

lib-sieve: enotify plugin: mailto method: Make sure from header is set to a usable address and not (null).

It's replaced with fd-util.h which is automatically included now.

It's replaced with fd-util.h which is automatically included now

Mirrors imap fix in Dovecot: 42149f48624b82fdf9631c256497580154c2e412

It's impossible for the command's pointer to be NULL at this point.
Previously, the command_find() would have returned NULL, but this check
presumably short-circuits that search in the trivial case, so has some
real use.

Problem now found by GCC 7.

Problem found by GCC 7.

lib-sieve: sieve-result: Added /* fall through */ comment to mark intentional switch case fall through.

Addresses GCC 7 warning.

plugins: Migrated from lib-lda/smtp-client.h to using lib-smtp/smtp-submit.h for message submission.

plugins/imapsieve: Initialize struct imap_sieve with full struct client, rather than individual fields.

lib-sieve: redirect action: Always set X-Sieve-Redirected-From header to sieve_user_email if configured.

Set it to the final recipient only when there is an envelope and sieve_user_email is unconfigured.