Before, the virtual mailbox name was not sanitized, which caused control
characters to be displayed in log messages. Also, the mailbox name would be
mentioned twice in the log message, once santized and once unsanitized.

Now using struct smtp_address rather than sieve_address.
In some cases, struct message_address may prove to be more suitable, but this is the best fit for now.
Adjusted to the renamed fields in struct mail_deliver_context.

lib-sieve: store action: Avoid NULL pointer dereference during rollback when transaction context is somehow unassigned.

This change matches the other transaction stages.
This will not currently happen though.
Reported by Coverity.

lib-sieve: store action: Made static analyzer happier about tr_context argument for sieve_act_store_add_flags().

Added an assert ensuring it is not NULL.

Used the following script:

C_FILES=`git ls-files *.c`
H_FILES=`git ls-files *.h`
for F in "$C_FILES $H_FILES"; do
        echo "$F"
  perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F
  perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F
  perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F
  perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F
done

Found with clang -Wstrict-bool.

Found with clang -Wstrict-bool.

Also improved handling of permission errors caused by ACL plugin.

This makes sure that the resulting mail storage events are of the correct type for logging/notification.

lib-sieve: Restructured result execution, so that all actions which involve mail storage are always committed before all others.

These caused a BUG error to be reported during delivery.
Solved by signalling the occurrence of storage errors as a separate execution status flag, rather than querying the last storage itself for errors, which won't work.

Logging was mixed up; it logged permanent SMTP failures as errors rather than mere info.
Redirect now handles temporary failure as a separate error condition, causing LDA to return a temporary failure if no other (storage) actions were performed.

Changed handling of ENOSPACE to a normal temporary failure and added handling of ENOQUOTA as a user error.
Patch by Timo Sirainen.

This way, a duplicate is only marked when the script execution succeeds, as required in the specification.

SMTP API now supports adding multiple recipients to a single SMTP transaction. This makes enotify/notify more efficient, since only one message is actually sent.

This change is bigger than I would have liked, so this needs to be tested more.

Passed senv->script_context rather than senv itself. Somehow the compiler fails to warn about this.

Added means to log user errors/warnings as info in master log.
Previous change was inadequate because an error was still logged.

Prevents administrator frustration about useless log messages caused by users with too much mail.

Also contains a few other small fixes by Timo.