Skip to content
Snippets Groups Projects
  • Stephan Bosch's avatar
    0b5e7b1a
    lib-sieve: sieve-result - Fix panic occurring upon temp fail after committed... · 0b5e7b1a
    Stephan Bosch authored
    lib-sieve: sieve-result - Fix panic occurring upon temp fail after committed keep-equivalent action.
    
    The determination of whether a keep-equivalent action was already executed is
    performed in sieve_result_implicit_keep_execute(), which can also be called from
    sieve_result_implicit_keep_finalize(). But there, the keep-equivalent status was
    checked before any call to sieve_result_implicit_keep_execute(), which would
    thus yield the wrong result.
    
    This change also makes the associated debug message more specific (otherwise two
    identical debug messages are logged) and an assert is added that makes sure the
    keep-equivalent action is actually finalized when the implicit keep was supposed
    to be finalized.
    
    Panic was:
    
    Panic: file sieve-result.c: line 1706 (sieve_result_implicit_keep_finalize): assertion failed: (aexec_keep->state == SIEVE_ACTION_EXECUTION_STATE_EXECUTED)
    0b5e7b1a
    History
    lib-sieve: sieve-result - Fix panic occurring upon temp fail after committed...
    Stephan Bosch authored
    lib-sieve: sieve-result - Fix panic occurring upon temp fail after committed keep-equivalent action.
    
    The determination of whether a keep-equivalent action was already executed is
    performed in sieve_result_implicit_keep_execute(), which can also be called from
    sieve_result_implicit_keep_finalize(). But there, the keep-equivalent status was
    checked before any call to sieve_result_implicit_keep_execute(), which would
    thus yield the wrong result.
    
    This change also makes the associated debug message more specific (otherwise two
    identical debug messages are logged) and an assert is added that makes sure the
    keep-equivalent action is actually finalized when the implicit keep was supposed
    to be finalized.
    
    Panic was:
    
    Panic: file sieve-result.c: line 1706 (sieve_result_implicit_keep_finalize): assertion failed: (aexec_keep->state == SIEVE_ACTION_EXECUTION_STATE_EXECUTED)

Consent

On this website, we use the web analytics service Matomo to analyze and review the use of our website. Through the collected statistics, we can improve our offerings and make them more appealing for you. Here, you can decide whether to allow us to process your data and set corresponding cookies for these purposes, in addition to technically necessary cookies. Further information on data protection—especially regarding "cookies" and "Matomo"—can be found in our privacy policy. You can withdraw your consent at any time.