From fd8b7199b71ef84bd453ec875adf462545d24f75 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan@rename-it.nl>
Date: Mon, 19 Nov 2007 21:21:27 +0100
Subject: [PATCH] Revised positional argument checking and fixed the
validator's error handling.
---
sieve/errors/address-errors.sieve | 2 +
sieve/errors/header-errors.sieve | 2 +
src/lib-sieve/cmd-redirect.c | 11 +--
src/lib-sieve/cmd-require.c | 6 +-
src/lib-sieve/ext-envelope.c | 17 ++---
src/lib-sieve/ext-fileinto.c | 11 ++-
src/lib-sieve/ext-reject.c | 4 +
.../plugins/subaddress/subaddress.sieve | 2 +-
src/lib-sieve/plugins/vacation/ext-vacation.c | 7 +-
src/lib-sieve/sieve-ast.c | 4 +-
src/lib-sieve/sieve-ast.h | 4 +-
src/lib-sieve/sieve-common.h | 2 +
src/lib-sieve/sieve-validator.c | 74 ++++++++++++-------
src/lib-sieve/sieve-validator.h | 5 ++
src/lib-sieve/tst-address.c | 73 +++++++++---------
src/lib-sieve/tst-exists.c | 8 +-
src/lib-sieve/tst-header.c | 55 +++++++-------
src/lib-sieve/tst-size.c | 8 +-
18 files changed, 164 insertions(+), 131 deletions(-)
diff --git a/sieve/errors/address-errors.sieve b/sieve/errors/address-errors.sieve
index 603320c83..4744f1d9c 100644
--- a/sieve/errors/address-errors.sieve
+++ b/sieve/errors/address-errors.sieve
@@ -1,3 +1,5 @@
+require "comparator-i;ascii-numeric";
+
if address :isnot :comparator "i;ascii-casemap" :localpart "From" "nico" {
discard;
}
diff --git a/sieve/errors/header-errors.sieve b/sieve/errors/header-errors.sieve
index 6c66b5ac3..ac6108ba1 100644
--- a/sieve/errors/header-errors.sieve
+++ b/sieve/errors/header-errors.sieve
@@ -1,3 +1,5 @@
+require "comparator-i;ascii-numeric";
+
if header :isnot :comparator "i;ascii-casemap" "From" "nico" {
discard;
}
diff --git a/src/lib-sieve/cmd-redirect.c b/src/lib-sieve/cmd-redirect.c
index 7143599bf..a45076a2b 100644
--- a/src/lib-sieve/cmd-redirect.c
+++ b/src/lib-sieve/cmd-redirect.c
@@ -6,23 +6,20 @@
bool cmd_redirect_validate(struct sieve_validator *validator, struct sieve_command_context *cmd)
{
- struct sieve_ast_argument *argument;
+ struct sieve_ast_argument *arg;
/* Check valid syntax
* Syntax: redirect <address: string>
*/
- if ( !sieve_validate_command_arguments(validator, cmd, 1, &argument) ||
+ if ( !sieve_validate_command_arguments(validator, cmd, 1, &arg) ||
!sieve_validate_command_subtests(validator, cmd, 0) ||
!sieve_validate_command_block(validator, cmd, FALSE, FALSE) ) {
return FALSE;
}
/* Check argument */
- if ( sieve_ast_argument_type(argument) != SAAT_STRING ) {
- /* Somethin else */
- sieve_command_validate_error(validator, cmd,
- "the redirect command accepts a single string argument (address) but %s was found",
- sieve_ast_argument_name(argument));
+ if ( !sieve_validate_positional_argument
+ (validator, cmd, arg, "address", 1, SAAT_STRING) ) {
return FALSE;
}
diff --git a/src/lib-sieve/cmd-require.c b/src/lib-sieve/cmd-require.c
index 738f6f826..ed03974bd 100644
--- a/src/lib-sieve/cmd-require.c
+++ b/src/lib-sieve/cmd-require.c
@@ -21,7 +21,8 @@ bool cmd_require_validate(struct sieve_validator *validator, struct sieve_comman
!sieve_ast_prev_cmd_is(cmd->ast_node, "require") ) ) {
sieve_command_validate_error(validator, cmd,
- "the require command can only be placed at top level at the beginning of the file");
+ "the require command can only be placed at top level "
+ "at the beginning of the file");
return FALSE;
}
@@ -61,7 +62,8 @@ bool cmd_require_validate(struct sieve_validator *validator, struct sieve_comman
} else {
/* Something else */
sieve_command_validate_error(validator, cmd,
- "the require command accepts a single string or string list argument but %s was found",
+ "the require command accepts a single string or string list argument, "
+ "but %s was found",
sieve_ast_argument_name(arg));
return FALSE;
}
diff --git a/src/lib-sieve/ext-envelope.c b/src/lib-sieve/ext-envelope.c
index 12bcae1ba..d3447983a 100644
--- a/src/lib-sieve/ext-envelope.c
+++ b/src/lib-sieve/ext-envelope.c
@@ -88,20 +88,17 @@ static bool tst_envelope_validate(struct sieve_validator *validator, struct siev
return FALSE;
}
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the envelope test expects a string-list as first argument (envelope part), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "envelope part", 1, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
arg = sieve_ast_argument_next(arg);
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the envelope test expects a string-list as second argument (key list), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "key list", 2, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
diff --git a/src/lib-sieve/ext-fileinto.c b/src/lib-sieve/ext-fileinto.c
index 42d0cbb53..d811b56d0 100644
--- a/src/lib-sieve/ext-fileinto.c
+++ b/src/lib-sieve/ext-fileinto.c
@@ -51,7 +51,7 @@ static bool cmd_fileinto_validate(struct sieve_validator *validator, struct siev
struct sieve_ast_argument *arg;
/* Check valid syntax:
- * reject <reason: string>
+ * fileinto <folder: string>
*/
if ( !sieve_validate_command_arguments(validator, cmd, 1, &arg) ||
!sieve_validate_command_subtests(validator, cmd, 0) ||
@@ -60,7 +60,10 @@ static bool cmd_fileinto_validate(struct sieve_validator *validator, struct siev
return FALSE;
}
-
+ if ( !sieve_validate_positional_argument
+ (validator, cmd, arg, "folder", 1, SAAT_STRING) ) {
+ return FALSE;
+ }
sieve_validator_argument_activate(validator, arg);
return TRUE;
@@ -85,8 +88,8 @@ static bool cmd_fileinto_generate
sieve_generator_emit_opcode_ext(generator, ext_my_id);
/* Generate arguments */
- if ( !sieve_generate_arguments(generator, ctx, NULL) )
- return FALSE;
+ if ( !sieve_generate_arguments(generator, ctx, NULL) )
+ return FALSE;
return TRUE;
}
diff --git a/src/lib-sieve/ext-reject.c b/src/lib-sieve/ext-reject.c
index 141123a02..bedc71c0e 100644
--- a/src/lib-sieve/ext-reject.c
+++ b/src/lib-sieve/ext-reject.c
@@ -68,6 +68,10 @@ static bool cmd_reject_validate(struct sieve_validator *validator, struct sieve_
return FALSE;
}
+ if ( !sieve_validate_positional_argument
+ (validator, cmd, arg, "reason", 1, SAAT_STRING) ) {
+ return FALSE;
+ }
sieve_validator_argument_activate(validator, arg);
return TRUE;
diff --git a/src/lib-sieve/plugins/subaddress/subaddress.sieve b/src/lib-sieve/plugins/subaddress/subaddress.sieve
index 1b4a0c715..7c2ab9329 100644
--- a/src/lib-sieve/plugins/subaddress/subaddress.sieve
+++ b/src/lib-sieve/plugins/subaddress/subaddress.sieve
@@ -8,7 +8,7 @@ if address :comparator "i;ascii-casemap" :user "from" "STEPHAN" {
keep;
stop;
}
- fileinto "INBOX.frop";
+ stop;
}
keep;
diff --git a/src/lib-sieve/plugins/vacation/ext-vacation.c b/src/lib-sieve/plugins/vacation/ext-vacation.c
index 085a1c5d1..d80c6392a 100644
--- a/src/lib-sieve/plugins/vacation/ext-vacation.c
+++ b/src/lib-sieve/plugins/vacation/ext-vacation.c
@@ -244,7 +244,8 @@ static bool cmd_vacation_registered(struct sieve_validator *validator, struct si
/* Command validation */
-static bool cmd_vacation_validate(struct sieve_validator *validator, struct sieve_command_context *cmd)
+static bool cmd_vacation_validate(struct sieve_validator *validator,
+ struct sieve_command_context *cmd)
{
struct sieve_ast_argument *arg;
@@ -260,6 +261,10 @@ static bool cmd_vacation_validate(struct sieve_validator *validator, struct siev
return FALSE;
}
+ if ( !sieve_validate_positional_argument
+ (validator, cmd, arg, "reason", 1, SAAT_STRING) ) {
+ return FALSE;
+ }
sieve_validator_argument_activate(validator, arg);
return TRUE;
diff --git a/src/lib-sieve/sieve-ast.c b/src/lib-sieve/sieve-ast.c
index b66658ac7..255d29bbf 100644
--- a/src/lib-sieve/sieve-ast.c
+++ b/src/lib-sieve/sieve-ast.c
@@ -243,8 +243,8 @@ struct sieve_ast_argument *sieve_ast_arguments_delete
return sieve_ast_arg_list_delete(first, count);
}
-const char *sieve_ast_argument_name(struct sieve_ast_argument *argument) {
- switch ( argument->type ) {
+const char *sieve_ast_argument_type_name(enum sieve_ast_argument_type arg_type) {
+ switch ( arg_type ) {
case SAAT_NONE: return "none";
case SAAT_STRING_LIST: return "a string list";
diff --git a/src/lib-sieve/sieve-ast.h b/src/lib-sieve/sieve-ast.h
index bfc60ec3e..6c7a65727 100644
--- a/src/lib-sieve/sieve-ast.h
+++ b/src/lib-sieve/sieve-ast.h
@@ -163,7 +163,9 @@ struct sieve_ast_argument *sieve_ast_argument_number_create
struct sieve_ast_argument *sieve_ast_arguments_delete
(struct sieve_ast_argument *first, unsigned int count);
-const char *sieve_ast_argument_name(struct sieve_ast_argument *argument);
+const char *sieve_ast_argument_type_name(enum sieve_ast_argument_type arg_type);
+#define sieve_ast_argument_name(argument) \
+ sieve_ast_argument_type_name((argument)->type)
void sieve_ast_stringlist_add
(struct sieve_ast_argument *list, const string_t *str, unsigned int source_line);
diff --git a/src/lib-sieve/sieve-common.h b/src/lib-sieve/sieve-common.h
index e60ee85d3..cb4994c62 100644
--- a/src/lib-sieve/sieve-common.h
+++ b/src/lib-sieve/sieve-common.h
@@ -15,6 +15,8 @@ typedef uint64_t sieve_number_t;
*/
/* sieve-ast.h */
+enum sieve_ast_argument_type;
+
struct sieve_ast;
struct sieve_ast_node;
struct sieve_ast_argument;
diff --git a/src/lib-sieve/sieve-validator.c b/src/lib-sieve/sieve-validator.c
index 2c2cd3f39..aeb39f2a5 100644
--- a/src/lib-sieve/sieve-validator.c
+++ b/src/lib-sieve/sieve-validator.c
@@ -329,7 +329,48 @@ inline const void *sieve_validator_extension_get_context(struct sieve_validator
return array_idx(&validator->ext_contexts, (unsigned int) ext_id);
}
-/* Tag Validation API */
+/* Argument Validation API */
+
+bool sieve_validate_positional_argument
+ (struct sieve_validator *validator, struct sieve_command_context *cmd,
+ struct sieve_ast_argument *arg, const char *arg_name, unsigned int arg_pos,
+ enum sieve_ast_argument_type req_type)
+{
+ if ( sieve_ast_argument_type(arg) != req_type &&
+ (sieve_ast_argument_type(arg) != SAAT_STRING ||
+ req_type != SAAT_STRING_LIST) )
+ {
+ sieve_command_validate_error(validator, cmd,
+ "the %s %s expects %s as argument %d (%s), but %s was found",
+ cmd->command->identifier, sieve_command_type_name(cmd->command),
+ sieve_ast_argument_type_name(req_type),
+ arg_pos, arg_name, sieve_ast_argument_name(arg));
+ return FALSE;
+ }
+
+ return TRUE;
+}
+
+void sieve_validator_argument_activate
+ (struct sieve_validator *validator ATTR_UNUSED, struct sieve_ast_argument *arg)
+{
+ switch ( sieve_ast_argument_type(arg) ) {
+ case SAAT_NUMBER:
+ arg->argument = &number_argument;
+ break;
+ case SAAT_STRING:
+ arg->argument = &string_argument;
+ break;
+ case SAAT_STRING_LIST:
+ arg->argument = &string_list_argument;
+ break;
+ case SAAT_TAG:
+ i_error("!!BUG!!: sieve_validator_argument_activate: cannot activate tagged argument.");
+ break;
+ default:
+ break;
+ }
+}
/* Test validation API */
@@ -428,27 +469,6 @@ bool sieve_validate_command_arguments
return TRUE;
}
-
-void sieve_validator_argument_activate
- (struct sieve_validator *validator ATTR_UNUSED, struct sieve_ast_argument *arg)
-{
- switch ( sieve_ast_argument_type(arg) ) {
- case SAAT_NUMBER:
- arg->argument = &number_argument;
- break;
- case SAAT_STRING:
- arg->argument = &string_argument;
- break;
- case SAAT_STRING_LIST:
- arg->argument = &string_list_argument;
- break;
- case SAAT_TAG:
- i_error("!!BUG!!: sieve_validator_argument_activate: cannot activate tagged argument.");
- break;
- default:
- break;
- }
-}
/* Command Validation API */
@@ -580,15 +600,16 @@ static bool sieve_validate_test(struct sieve_validator *validator, struct sieve_
static bool sieve_validate_test_list(struct sieve_validator *validator, struct sieve_ast_node *test_list)
{
+ bool result = TRUE;
struct sieve_ast_node *test;
test = sieve_ast_test_first(test_list);
while ( test != NULL ) {
- sieve_validate_test(validator, test);
+ result = result && sieve_validate_test(validator, test);
test = sieve_ast_test_next(test);
}
- return TRUE;
+ return result;
}
static bool sieve_validate_command(struct sieve_validator *validator, struct sieve_ast_node *cmd_node)
@@ -646,17 +667,18 @@ static bool sieve_validate_command(struct sieve_validator *validator, struct sie
static bool sieve_validate_block(struct sieve_validator *validator, struct sieve_ast_node *block)
{
+ bool result = TRUE;
struct sieve_ast_node *command;
t_push();
command = sieve_ast_command_first(block);
while ( command != NULL ) {
- sieve_validate_command(validator, command);
+ result = result && sieve_validate_command(validator, command);
command = sieve_ast_command_next(command);
}
t_pop();
- return TRUE;
+ return result;
}
bool sieve_validator_run(struct sieve_validator *validator) {
diff --git a/src/lib-sieve/sieve-validator.h b/src/lib-sieve/sieve-validator.h
index f980b6dea..601e5200f 100644
--- a/src/lib-sieve/sieve-validator.h
+++ b/src/lib-sieve/sieve-validator.h
@@ -37,9 +37,14 @@ void sieve_validator_link_match_type_tags
unsigned int id_code);
/* Argument validation */
+
bool sieve_validate_command_arguments
(struct sieve_validator *validator, struct sieve_command_context *tst,
const unsigned int count, struct sieve_ast_argument **first_positional);
+bool sieve_validate_positional_argument
+ (struct sieve_validator *validator, struct sieve_command_context *cmd,
+ struct sieve_ast_argument *arg, const char *arg_name, unsigned int arg_pos,
+ enum sieve_ast_argument_type req_type);
void sieve_validator_argument_activate
(struct sieve_validator *validator, struct sieve_ast_argument *arg);
diff --git a/src/lib-sieve/tst-address.c b/src/lib-sieve/tst-address.c
index cb65d0c71..69ef9c038 100644
--- a/src/lib-sieve/tst-address.c
+++ b/src/lib-sieve/tst-address.c
@@ -58,20 +58,17 @@ bool tst_address_validate(struct sieve_validator *validator, struct sieve_comman
tst->data = arg;
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the address test expects a string-list as first argument (header list), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "header list", 1, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
-
+
arg = sieve_ast_argument_next(arg);
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the address test expects a string-list as second argument (key list), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "key list", 2, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
@@ -104,26 +101,26 @@ static bool tst_address_opcode_dump
printf("ADDRESS\n");
/* Handle any optional arguments */
- if ( sieve_operand_optional_present(sbin, address) ) {
- while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
- switch ( opt_code ) {
- case OPT_COMPARATOR:
+ if ( sieve_operand_optional_present(sbin, address) ) {
+ while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
+ switch ( opt_code ) {
+ case OPT_COMPARATOR:
if ( !sieve_opr_comparator_dump(interp, sbin, address) )
return FALSE;
- break;
- case OPT_MATCH_TYPE:
+ break;
+ case OPT_MATCH_TYPE:
if ( !sieve_opr_match_type_dump(interp, sbin, address) )
- return FALSE;
- break;
+ return FALSE;
+ break;
case OPT_ADDRESS_PART:
if ( !sieve_opr_address_part_dump(interp, sbin, address) )
return FALSE;
break;
- default:
- return FALSE;
- }
- }
- }
+ default:
+ return FALSE;
+ }
+ }
+ }
return
sieve_opr_stringlist_dump(sbin, address) &&
@@ -149,26 +146,26 @@ static bool tst_address_opcode_execute
printf("?? ADDRESS\n");
/* Handle any optional arguments */
- if ( sieve_operand_optional_present(sbin, address) ) {
- while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
- switch ( opt_code ) {
- case OPT_COMPARATOR:
- if ( (cmp = sieve_opr_comparator_read(interp, sbin, address)) == NULL )
+ if ( sieve_operand_optional_present(sbin, address) ) {
+ while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
+ switch ( opt_code ) {
+ case OPT_COMPARATOR:
+ if ( (cmp = sieve_opr_comparator_read(interp, sbin, address)) == NULL )
return FALSE;
- break;
- case OPT_MATCH_TYPE:
- if ( (mtch = sieve_opr_match_type_read(interp, sbin, address)) == NULL )
+ break;
+ case OPT_MATCH_TYPE:
+ if ( (mtch = sieve_opr_match_type_read(interp, sbin, address)) == NULL )
return FALSE;
- break;
+ break;
case OPT_ADDRESS_PART:
if ( (addrp = sieve_opr_address_part_read(interp, sbin, address)) == NULL )
return FALSE;
break;
- default:
- return FALSE;
- }
- }
- }
+ default:
+ return FALSE;
+ }
+ }
+ }
t_push();
diff --git a/src/lib-sieve/tst-exists.c b/src/lib-sieve/tst-exists.c
index e515c089e..d5c1d3796 100644
--- a/src/lib-sieve/tst-exists.c
+++ b/src/lib-sieve/tst-exists.c
@@ -30,11 +30,9 @@ bool tst_exists_validate(struct sieve_validator *validator, struct sieve_command
return FALSE;
}
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the exists test expects a string-list as only argument (header names), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "header names", 1, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
diff --git a/src/lib-sieve/tst-header.c b/src/lib-sieve/tst-header.c
index ff42d2484..30567c032 100644
--- a/src/lib-sieve/tst-header.c
+++ b/src/lib-sieve/tst-header.c
@@ -51,20 +51,17 @@ bool tst_header_validate(struct sieve_validator *validator, struct sieve_command
!sieve_validate_command_subtests(validator, tst, 0) )
return FALSE;
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the header test expects a string-list as first argument (header names), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "header names", 1, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
arg = sieve_ast_argument_next(arg);
- if ( sieve_ast_argument_type(arg) != SAAT_STRING && sieve_ast_argument_type(arg) != SAAT_STRING_LIST ) {
- sieve_command_validate_error(validator, tst,
- "the header test expects a string-list as second argument (key list), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "key list", 2, SAAT_STRING_LIST) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
@@ -79,8 +76,8 @@ bool tst_header_generate
sieve_generator_emit_opcode(generator, SIEVE_OPCODE_HEADER);
/* Generate arguments */
- if ( !sieve_generate_arguments(generator, ctx, NULL) )
- return FALSE;
+ if ( !sieve_generate_arguments(generator, ctx, NULL) )
+ return FALSE;
return TRUE;
}
@@ -93,7 +90,7 @@ static bool tst_header_opcode_dump
{
unsigned int opt_code;
- printf("HEADER\n");
+ printf("HEADER\n");
/* Handle any optional arguments */
if ( sieve_operand_optional_present(sbin, address) ) {
@@ -112,8 +109,8 @@ static bool tst_header_opcode_dump
}
return
- sieve_opr_stringlist_dump(sbin, address) &&
- sieve_opr_stringlist_dump(sbin, address);
+ sieve_opr_stringlist_dump(sbin, address) &&
+ sieve_opr_stringlist_dump(sbin, address);
}
/* Code execution */
@@ -134,20 +131,20 @@ static bool tst_header_opcode_execute
printf("?? HEADER\n");
/* Handle any optional arguments */
- if ( sieve_operand_optional_present(sbin, address) ) {
- while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
- switch ( opt_code ) {
- case OPT_COMPARATOR:
- cmp = sieve_opr_comparator_read(interp, sbin, address);
- break;
- case OPT_MATCH_TYPE:
- mtch = sieve_opr_match_type_read(interp, sbin, address);
- break;
- default:
- return FALSE;
- }
- }
- }
+ if ( sieve_operand_optional_present(sbin, address) ) {
+ while ( (opt_code=sieve_operand_optional_read(sbin, address)) ) {
+ switch ( opt_code ) {
+ case OPT_COMPARATOR:
+ cmp = sieve_opr_comparator_read(interp, sbin, address);
+ break;
+ case OPT_MATCH_TYPE:
+ mtch = sieve_opr_match_type_read(interp, sbin, address);
+ break;
+ default:
+ return FALSE;
+ }
+ }
+ }
t_push();
diff --git a/src/lib-sieve/tst-size.c b/src/lib-sieve/tst-size.c
index 2ddca289c..5823e4ca1 100644
--- a/src/lib-sieve/tst-size.c
+++ b/src/lib-sieve/tst-size.c
@@ -114,11 +114,9 @@ bool tst_size_validate(struct sieve_validator *validator, struct sieve_command_c
return FALSE;
}
- if ( sieve_ast_argument_type(arg) != SAAT_NUMBER ) {
- sieve_command_validate_error(validator, tst,
- "the size test expects a number as argument (limit), but %s was found",
- sieve_ast_argument_name(arg));
- return FALSE;
+ if ( !sieve_validate_positional_argument
+ (validator, tst, arg, "limit", 1, SAAT_NUMBER) ) {
+ return FALSE;
}
sieve_validator_argument_activate(validator, arg);
--
GitLab