From e25f31a3800fb0f9e25114ec7d6d287c74ea1cf0 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan@rename-it.nl>
Date: Tue, 26 Apr 2016 21:13:04 +0200
Subject: [PATCH] lib-sieve: validator: Fixed potential NULL dereference in
sieve_validator_extension_load().
Would only happen with dummy/internal `extensions' that have no valid ID.
This caused a Coverity defect report.
---
src/lib-sieve/sieve-validator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib-sieve/sieve-validator.c b/src/lib-sieve/sieve-validator.c
index b298ed76f..a8ab04f4b 100644
--- a/src/lib-sieve/sieve-validator.c
+++ b/src/lib-sieve/sieve-validator.c
@@ -649,10 +649,10 @@ bool sieve_validator_extension_load
return FALSE;
/* Link extension to AST for use at code generation */
- sieve_ast_extension_link(valdtr->ast, ext, reg->required);
-
- if ( reg != NULL )
+ if ( reg != NULL ) {
+ sieve_ast_extension_link(valdtr->ast, ext, reg->required);
reg->loaded = TRUE;
+ }
return TRUE;
}
--
GitLab