From d188419fefb0bff9a5edf9d94231098cf2ef0938 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Sat, 8 Jul 2017 10:51:27 +0200
Subject: [PATCH] sieve-tools: sieve-filter: Forgot to clean up script binary
 at end of execution.

Normally, this would merely be an inconsequential memory leak.
However, when the script comes from an LDAP storage, the storage is not closed before master_service_deinit() -> io_loop_destroy().
The LDAP connection's stale io can cause problems while closing the main ioloop.
---
 src/sieve-tools/sieve-filter.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/sieve-tools/sieve-filter.c b/src/sieve-tools/sieve-filter.c
index 0c986a41b..4a2b91a8b 100644
--- a/src/sieve-tools/sieve-filter.c
+++ b/src/sieve-tools/sieve-filter.c
@@ -583,6 +583,10 @@ int main(int argc, char **argv)
 	if ( move_box != NULL )
 		mailbox_free(&move_box);
 
+	/* Close the script binary */
+	if ( main_sbin != NULL )
+		sieve_close(&main_sbin);
+
 	/* Cleanup error handler */
 	sieve_error_handler_unref(&ehandler);
 
-- 
GitLab