From d04c3011eab24d52e7efa444b5aa66462e59c356 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan@rename-it.nl>
Date: Sat, 11 Oct 2008 23:13:16 +0200
Subject: [PATCH] Removed/solved minor TODOs.
---
.../plugins/imapflags/ext-imapflags-common.c | 4 ++--
src/lib-sieve/sieve-binary.c | 13 ++++++-------
src/lib-sieve/sieve-parser.c | 4 ----
3 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/src/lib-sieve/plugins/imapflags/ext-imapflags-common.c b/src/lib-sieve/plugins/imapflags/ext-imapflags-common.c
index 1196a850a..cfb76cbce 100644
--- a/src/lib-sieve/plugins/imapflags/ext-imapflags-common.c
+++ b/src/lib-sieve/plugins/imapflags/ext-imapflags-common.c
@@ -304,8 +304,8 @@ static bool flag_is_valid(const char *flag)
(strcmp(atom, "\\SEEN") != 0) &&
(strcmp(atom, "\\DRAFT") != 0) )
{
- return FALSE;
- }
+ return FALSE;
+ }
} else {
/* Custom keyword:
*
diff --git a/src/lib-sieve/sieve-binary.c b/src/lib-sieve/sieve-binary.c
index 0c48faa40..8e3851527 100644
--- a/src/lib-sieve/sieve-binary.c
+++ b/src/lib-sieve/sieve-binary.c
@@ -745,7 +745,6 @@ static bool _file_memory_load(struct sieve_binary_file *file)
i_assert(file->fd > 0);
/* Allocate memory buffer
- * FIXME: provide mmap support
*/
indata = p_malloc(file->pool, file->st.st_size);
size = file->st.st_size;
@@ -1706,11 +1705,11 @@ const void *sieve_binary_read_extension_object
{
unsigned int code;
- if ( reg->count == 0 )
- return NULL;
+ if ( reg->count == 0 )
+ return NULL;
- if ( reg->count == 1 )
- return reg->objects;
+ if ( reg->count == 1 )
+ return reg->objects;
if ( ADDR_BYTES_LEFT(sbin, address) <= 0 )
return NULL;
@@ -1718,8 +1717,8 @@ const void *sieve_binary_read_extension_object
code = ADDR_DATA_AT(sbin, address);
ADDR_JUMP(address, 1);
- if ( code >= reg->count )
+ if ( code >= reg->count )
return NULL;
- return ((const void *const *) reg->objects)[code];
+ return ((const void *const *) reg->objects)[code];
}
diff --git a/src/lib-sieve/sieve-parser.c b/src/lib-sieve/sieve-parser.c
index dca725d4b..03215b283 100644
--- a/src/lib-sieve/sieve-parser.c
+++ b/src/lib-sieve/sieve-parser.c
@@ -15,10 +15,6 @@
#include "sieve-error.h"
#include "sieve-ast.h"
-/* FIXME: Enforce maximums on the number of arguments, tests, commands,
- * nesting levels, etc.
- */
-
/*
* Forward declarations
*/
--
GitLab