From 993bb23b60aa5999f2d3c0470e4e1fec61405395 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan.bosch@dovecot.fi>
Date: Tue, 11 Dec 2018 10:41:51 +0100
Subject: [PATCH] plugins: imap-filter-sieve: Remove useless NULL check for
 exec_status.

In this context, it can never be NULL and the check confuses Coverity.
---
 src/plugins/imap-filter-sieve/imap-filter-sieve.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/plugins/imap-filter-sieve/imap-filter-sieve.c b/src/plugins/imap-filter-sieve/imap-filter-sieve.c
index 61d0c32c1..60d6dd0a5 100644
--- a/src/plugins/imap-filter-sieve/imap-filter-sieve.c
+++ b/src/plugins/imap-filter-sieve/imap-filter-sieve.c
@@ -607,8 +607,7 @@ imap_sieve_filter_handle_exec_status(struct imap_filter_sieve_context *sctx,
 
 	error_func = user_error_func = sieve_sys_error;
 
-	if (estatus != NULL && estatus->last_storage != NULL &&
-	    estatus->store_failed) {
+	if (estatus->last_storage != NULL && estatus->store_failed) {
 		(void)mail_storage_get_last_error(estatus->last_storage,
 						  &mail_error);
 
-- 
GitLab