From 552611e2e59c3df69e7de46212a71dab0c7af9d1 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Mon, 4 Jan 2021 05:22:40 +0100
Subject: [PATCH] plugins: imap-filter-sieve: Fix useless addition of internal
 error message to FILTER SIEVE errors.

---
 src/plugins/imap-filter-sieve/imap-filter-sieve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/imap-filter-sieve/imap-filter-sieve.c b/src/plugins/imap-filter-sieve/imap-filter-sieve.c
index 97e8faa07..3956f8aa8 100644
--- a/src/plugins/imap-filter-sieve/imap-filter-sieve.c
+++ b/src/plugins/imap-filter-sieve/imap-filter-sieve.c
@@ -1012,7 +1012,7 @@ int imap_sieve_filter_run_mail(struct imap_filter_sieve_context *sctx,
 						    &msgdata, scriptenv);
 	} T_END;
 
-	if (ret < 0 || str_len(sctx->errors) == 0) {
+	if (ret < 0 && str_len(sctx->errors) == 0) {
 		/* Failed, but no user error was logged: log a generic internal
 		   error instead. */
 		sieve_internal_error(user_ehandler, NULL, NULL);
-- 
GitLab