From 45e64f2ca52e22fd85c87637671cb1dc10df19e1 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan@rename-it.nl>
Date: Sat, 1 Aug 2009 22:40:21 +0200
Subject: [PATCH] Updated TODO and added a FIXME to the mailbox extension (no
 ACL support yet, but required by RFC).

---
 TODO                                              | 6 ++----
 src/lib-sieve/plugins/mailbox/cmd-mailboxexists.c | 3 +++
 src/lib-sieve/plugins/mailbox/ext-mailbox.c       | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/TODO b/TODO
index 9a08702b1..eaa307a86 100644
--- a/TODO
+++ b/TODO
@@ -4,14 +4,11 @@ Current activities:
   script.
 	- Add commandline options to fully customixe execution
 	- Write manual page
-* Implement the mailbox extension
-	- Implement mailboxexists command
-	- Build testsuite tests
 * Testsuite:
 	- add support for testing binary load/save
 	- add support for testing messages stored into a mailbox by looping these back
 	  as the tested mail message
-	- add execution tests for fileinto, imap4flags and mailbox extensions.
+	- add execution tests for fileinto and imap4flags extensions.
 
 Next (in order of descending priority/precedence):
 
@@ -70,6 +67,7 @@ Next (in order of descending priority/precedence):
 	  are tested at least once.
 * Code cleanup:
 	- Make address handling more uniform. 
+	- Review all FIXMEs 
 
 * Build a server with test mail accounts that processes lots and lots of mail 
   (e.g. spam, mailing lists etc.)
diff --git a/src/lib-sieve/plugins/mailbox/cmd-mailboxexists.c b/src/lib-sieve/plugins/mailbox/cmd-mailboxexists.c
index f838f3067..67f0a024a 100644
--- a/src/lib-sieve/plugins/mailbox/cmd-mailboxexists.c
+++ b/src/lib-sieve/plugins/mailbox/cmd-mailboxexists.c
@@ -158,6 +158,9 @@ static int tst_mailboxexists_operation_execute
 			if ( mailbox_is_readonly(box) )
 				all_exist = FALSE;
 
+			/* FIXME: check acl for 'p' or 'i' ACL permissions as required by RFC */
+
+			/* Close mailbox */
 			mailbox_close(&box);
 		}
 	}
diff --git a/src/lib-sieve/plugins/mailbox/ext-mailbox.c b/src/lib-sieve/plugins/mailbox/ext-mailbox.c
index 3ea658802..3419e3c90 100644
--- a/src/lib-sieve/plugins/mailbox/ext-mailbox.c
+++ b/src/lib-sieve/plugins/mailbox/ext-mailbox.c
@@ -6,7 +6,7 @@
  *
  * Authors: Stephan Bosch
  * Specification: RFC 5490
- * Implementation: full
+ * Implementation: almost full; acl support is missing for mailboxexists
  * Status: experimental, largely untested
  * 
  */
-- 
GitLab