From 0d2e6d2ad376f9785a00fc3e1308eaea752ea9fa Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sun, 20 Oct 2024 02:10:16 +0200
Subject: [PATCH] lib-sieve: sieve-storage - Fix error handling for
 sieve_storage_active_script_open()

---
 src/lib-sieve/sieve-storage.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/lib-sieve/sieve-storage.c b/src/lib-sieve/sieve-storage.c
index 9cf3a69b9..caafd6294 100644
--- a/src/lib-sieve/sieve-storage.c
+++ b/src/lib-sieve/sieve-storage.c
@@ -947,8 +947,7 @@ int sieve_storage_active_script_open(struct sieve_storage *storage,
 	if (ret == 0 ||
 	    (storage->flags & SIEVE_STORAGE_FLAG_SYNCHRONIZING) != 0 ||
 	    storage->default_location == NULL) {
-		i_assert(script != NULL);
-		if (error_code_r != NULL)
+		if (ret < 0 && error_code_r != NULL)
 			*error_code_r = storage->error_code;
 		*script_r = script;
 		return ret;
-- 
GitLab