From 0b04d67d3c301a9f5cfba38d8cff9b923866fc64 Mon Sep 17 00:00:00 2001
From: Stephan Bosch <stephan@rename-it.nl>
Date: Tue, 26 Apr 2016 21:27:08 +0200
Subject: [PATCH] lib-sieve: vnd.dovecot.report extension: Removed logically
dead code.
This caused Coverity defect reports.
---
src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c b/src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c
index 5e57aee90..62cd4c153 100644
--- a/src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c
+++ b/src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c
@@ -261,7 +261,6 @@ static bool cmd_report_operation_dump
/* Dump optional operands */
for (;;) {
int opt;
- bool opok = TRUE;
if ( (opt=sieve_opr_optional_dump
(denv, address, &opt_code)) < 0 )
@@ -276,8 +275,6 @@ static bool cmd_report_operation_dump
default:
return FALSE;
}
-
- if ( !opok ) return FALSE;
}
return
@@ -318,14 +315,11 @@ static int cmd_report_operation_execute
switch ( opt_code ) {
case OPT_HEADERS_ONLY:
headers_only = TRUE;
- ret = SIEVE_EXEC_OK;
break;
default:
sieve_runtime_trace_error(renv, "unknown optional operand");
return SIEVE_EXEC_BIN_CORRUPT;
}
-
- if ( ret <= 0 ) return ret;
}
/* Fixed operands */
--
GitLab